Ticket #517 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Normalize all signal connections

Reported by: valerio Owned by:
Priority: major Milestone: open
Component: Other Version: 2.0
Keywords: Cc:

Description

When we have a method like this: method( const type1 &arg1, const type2 arg2, type3 *arg3, type4 arg4 )

and we need to connect() it, instead of the full type-only form:
method(const type1&,const type2,type3*,type4)
we can just use the normalized version of it:
method(type1,type2,type3*,type4)

This way,

connect( object, SIGNAL(   call(const type1&,const type2,type3*,type4) ),
         this,   SLOT  ( method(const type1&,const type2,type3*,type4) ) );

becomes

connect( object, SIGNAL(   call(type1,type2,type3*,type4) ),
         this,   SLOT  ( method(type1,type2,type3*,type4) ) );

I'm sure the difference is obvious - a lot less line length issues, specially when we consider that aligning the code to adhere to the coding style makes for 130+ columns wide lines of code. :P

Change History

Changed 2 years ago by valerio

  • status changed from new to closed
  • resolution set to fixed

Done by Camille Begue and me as r5317. Thanks!

Note: See TracTickets for help on using tickets.