Ticket #350 (assigned enhancement)

Opened 3 years ago

Last modified 3 years ago

Add optional cmake check for kdebase-runtime

Reported by: diederik Owned by: diederik
Priority: minor Milestone: kmess-3.0
Component: Deployment Version: 2.0-alpha
Keywords: Cc:

Description

Based on the experiences in this topic: http://www.kmess.org/board/viewtopic.php?f=3&t=3307 I think we need to add another check for 'kdebase-runtime'. Ubuntu splits out their packages in such a way that:

  • a phonon backend is not installed.
  • kdebase-runtime is not installed (which includes knotify, servicetypes/phonon.desktop, khelpcenter etc on openSUSE).

I think a check for a file in kdebase-runtime should be enough; the dependencies of this package should be set properly by Ubuntu.

This check can be optional; after all KMess can compile properly without kdebase-runtime. However, making a notice of the missing kdebase-runtime package should make users aware of why their sound is not working (and avoid more questions about this).

Attachments

FindKDE4Runtime.cmake Download (472 bytes) - added by diederik 3 years ago.
cmake check for kdebase-runtime
phononCheck.patch Download (1.5 KB) - added by valerio 3 years ago.
Is this what you meant?

Change History

Changed 3 years ago by diederik

cmake check for kdebase-runtime

Changed 3 years ago by diederik

  • status changed from new to assigned
  • owner set to diederik

I've implemented a check for kdebase-runtime but figured it shouldn't be implemented at cmake level at all. This is annoying for build servers. Instead we should add some runtime checks in C++ at KMess startup. Much like the way we check for the kmess.notifyrc file.

Changed 3 years ago by diederik

btw to add this check, the following line is also needed in CMakeLists.txt:

SET( CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${PROJECT_SOURCE_DIR}/cmake )

Changed 3 years ago by valerio

Is this what you meant?

Changed 3 years ago by valerio

Ok now: Milestone 2.0 or 2.1 ? ;)

Changed 3 years ago by diederik

That patch seams cool, and delaying this update is fine with me :)

Changed 3 years ago by valerio

  • milestone changed from kmess-2.0 to kmess-2.1

Ok, and also, the string freeze wouldn't appreciate the dialog box! Moving to 2.1

Note: See TracTickets for help on using tickets.