Ticket #320 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Change the algorithm of the 'connection timeout' check.

Reported by: diederik Owned by:
Priority: minor Milestone: kmess-2.0
Component: Protocol - core Version: 2.0-alpha
Keywords: Cc:

Description

Currently KMess has a timer running to detect connection timeouts. It expects KMess to be fully logged in within ~2minutes. When the contact list is large, and the connection is slow this fails half way.

I'd propose to change the algorithm into:

  • run a shorter timer.
  • reset it each time something was received from the server.

Change History

Changed 3 months ago by valerio

  • status changed from new to closed
  • resolution set to fixed

It's a very good idea. I found the login timer quite dumb, as there's no guarantee of latency or speed when dealing with slow or congested networks: this is a perfect replacement.

I've fixed this ticket in rev r3689.

The timer is now 15 seconds long, and if no server commands do arrive in that time span, the connection is closed; however, if a message arrives, the timer is restarted from 15 seconds.

I've also added the contact list loading percentage, just for good measure ;)

Note: See TracTickets for help on using tickets.