Restoring a chat after being disconnected got broken

[diederik]

KMess was not able to restore a chat which became grayed out because the user got temporary disconnected.

First it seams there are problems with de-initializing:

WARNING: kmess(10487) ContactFrame::contactDestroyed: Received unexpected contact reference.
WARNING: kmess(10487) ContactFrame::contactDestroyed: Received unexpected contact reference.
kmess(10487) Contact::~Contact: DESTROYED. [handle= "omega123456@hotmail.com" ]
WARNING: kmess(10487) ContactFrame::contactDestroyed: Received unexpected contact reference.

I had 2 chat tabs, one normal chat with 'amroth', and the second one a groupchat with 'amroth' and 'sifcenter'.

When restoring the chat, one of the chat tabs seams to cause issues:

kmess(10487) ChatMaster::getApplicationList: Creating application list for contact  "amroth@coldshock.net"
kmess(10487) ChatMaster::startMsnObjectDownload: Contact MsnObject is already in cache.
kmess(10487) ContactFrame::updatePicture: Picture was already loaded.
kmess(10487) ContactSidebar::contactJoined: "amroth@coldshock.net"
kmess(10487) ContactFrame::setDisplayMode: Frame ContactFrame(0x8a11f68, name = "ContactFrame") - Enabled: true
kmess(10487) ContactSidebar::contactJoined: "amroth@coldshock.net"
kmess(10487) ContactFrame::setDisplayMode: Frame ContactFrame(0x96881e0, name = "ContactFrame") - Enabled: true
WARNING: kmess(10487) CrashHandler::kmessCrashed: "KMess crashed! -- this should not happen.

Relevant part of the backtrace:

#3  <signal handler called>
#4  0x08072b94 in QBasicAtomicInt::ref (this=0xc2c0) at /usr/include/QtCore/qatomic_i386.h:121
#5  0x08073798 in QString (this=0xbfc09728, other=@0x83bf288) at /usr/include/QtCore/qstring.h:677
#6  0x080a22e2 in ContactBase::getHandle (this=0x83bf268) at /home/diederik/development/kmess2/src/contact/contactbase.cpp:434
#7  0x08097a8c in ContactAction::getHandle (this=0x965a9e0) at /home/diederik/development/kmess2/src/chat/contactaction.cpp:69
#8  0x080836a2 in ChatView::getContactActionByHandle (this=0x8d9d430, handle=@0xbfc09818) at /home/diederik/development/kmess2/src/chat/chatview.cpp:442
#9  0x0808e13d in Chat::contactJoined (this=0x8d9d430, handle=@0xbfc09818, friendlyName=@0xbfc09814) at /home/diederik/development/kmess2/src/chat/chat.cpp:156
#10 0x0808e985 in Chat::qt_metacall (this=0x8d9d430, _c=QMetaObject::InvokeMetaMethod, _id=18, _a=0xbfc098fc) at /home/diederik/development/kmess2/build-debug/src/chat.moc:134
#11 0xb6fe936a in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#12 0xb6fe97b2 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#13 0x080e3bcb in MsnSwitchboardConnection::contactJoinedChat (this=0x8d70bc0, _t1=@0xbfc09950, _t2=@0xbfc0994c) at /home/diederik/development/kmess2/build-debug/src/msnswitchboardconnection.moc:142
#14 0x080e9299 in MsnSwitchboardConnection::contactJoined (this=0x8d70bc0, handle=@0xbfc0998c, friendlyName=@0xbfc09988, capabilities=1342210084) at /home/diederik/development/kmess2/src/network/msnswitchboardconnection.cpp:405
#15 0x080e93b3 in MsnSwitchboardConnection::gotJoi (this=0x8d70bc0, command=@0xbfc09ca8) at /home/diederik/development/kmess2/src/network/msnswitchboardconnection.cpp:646

[valerio]

Should have been fixed with r3423.

[diederik]

great! :)