Ticket #228 (closed defect: fixed)

Opened 3 months ago

Last modified 4 weeks ago

Fix the .pot file, contains strings of translators

Reported by: diederik Owned by: diederik
Priority: major Milestone: kmess-2.0
Component: Translations Version: 2.0-alpha
Keywords: Cc:

Description

The .pot file contains useless strings at the moment; names of translators and debug messages (or context messages?). This could be a xgettext version issue, or we have the wrong calls in our KDE 4 code.

Attachments

ignore_contributor_names.patch (19.5 kB) - added by valerio 4 weeks ago.

Change History

Changed 3 months ago by diederik

  • owner set to diederik
  • status changed from new to assigned

- fixed object names in titles - fixed generating the .pot file

remaining issues: - author names (from main.cpp) - HTML code from the network window.

Changed 3 months ago by diederik

HTML code should be done now with r3295.

Changed 3 months ago by valerio

  • status changed from assigned to closed
  • resolution set to fixed

Fixed the issue as of r3310: it was due to ki18n() calls for contributors names.

About the contributors names in the source file: as long as main.cpp remains UTF8 encoded, there's no risk of losing anything.

Changed 3 months ago by valerio

Note that I removed the ki18n() calls since person names will never need to be translated.

Changed 3 months ago by diederik

  • status changed from closed to reopened
  • resolution deleted

hmm running maketrans restores the names in the files. Options we have

  • add all those names to kmess.pot.ignore (quick hack)
  • find out how our main.cpp code or xgettext command should be to avoid this issue completely.

For reference, the original report was at: http://www.kmess.org/board/viewtopic.php?f=6&t=3205

Changed 4 weeks ago by valerio

Changed 4 weeks ago by valerio

Can anyone check out if the attached patch fixes the .po files? I'm too tired at the moment, and also uncertain if running mergetrans will delete the strings removed from the code or keep them.

Changed 4 weeks ago by valerio

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r3589.

Changed 4 weeks ago by diederik

  • status changed from closed to reopened
  • resolution deleted

Just asked at IRC about this. It turns out some languages like to change the special characters in names to their localized version. So it's not a bug but a feature, and got the request to please don't #define ki18n.

Changed 4 weeks ago by diederik

  • status changed from reopened to closed
  • resolution set to fixed

Fixed as of r3621.

Note: See TracTickets for help on using tickets.