Fix compilation warnings under new GCC

[valerio]

Here's the build log obtained compiling KMess2 from OpenSUSE 11.0 beta1, with KDE4 and GCC 4.3.1:

[ 46%] Building CXX object src/CMakeFiles/kmess.dir/network/msnswitchboardconnection.o
/media/susina/home/amroth/kmess/trunk/src/network/msnconnection.cpp: In member function ‘void MsnConnection::writeData(const QString&)’:
/media/susina/home/amroth/kmess/trunk/src/network/msnconnection.cpp:771: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/msnconnection.cpp: In member function ‘void MsnConnection::writeBinaryData(const QByteArray&)’:
/media/susina/home/amroth/kmess/trunk/src/network/msnconnection.cpp:810: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/msnnotificationconnection.cpp: In member function ‘void MsnNotificationConnection::gotXfr(const QStringList&)’:
/media/susina/home/amroth/kmess/trunk/src/network/msnnotificationconnection.cpp:1822: warning: conversion to ‘quint16’ from ‘int’ may alter its value
[ 47%] Building CXX object src/CMakeFiles/kmess.dir/network/multipacketmessage.o
[ 47%] Building CXX object src/CMakeFiles/kmess.dir/network/p2pmessage.o
/media/susina/home/amroth/kmess/trunk/src/network/p2pmessage.cpp: In static member function ‘static void P2PMessage::insertNonce(QByteArray&, const QString&, int)’:
/media/susina/home/amroth/kmess/trunk/src/network/p2pmessage.cpp:329: warning: conversion to ‘char’ from ‘uint’ may alter its value
In file included from /usr/include/QtCore/QtCore:24,
                 from /media/susina/home/amroth/kmess/trunk/src/network/msnswitchboardconnection.cpp:20:
/usr/include/QtCore/qendian.h: In function ‘T qFromLittleEndian(const uchar*) [with T = short unsigned int]’:
/usr/include/QtCore/qendian.h:156: warning: conversion to ‘quint16’ from ‘int’ may alter its value
/usr/include/QtCore/qendian.h: In function ‘T qFromBigEndian(const uchar*) [with T = short unsigned int]’:
/usr/include/QtCore/qendian.h:248: warning: conversion to ‘quint16’ from ‘int’ may alter its value
/usr/include/QtCore/qendian.h: In function ‘T qbswap(T) [with T = short unsigned int]’:
/usr/include/QtCore/qendian.h:295: warning: conversion to ‘quint16’ from ‘int’ may alter its value
In file included from /usr/include/QtCore/QtCore:53,
                 from /media/susina/home/amroth/kmess/trunk/src/network/msnswitchboardconnection.cpp:20:
/usr/include/QtCore/qmath.h: In function ‘int qCeil(qreal)’:
/usr/include/QtCore/qmath.h:61: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘int qFloor(qreal)’:
/usr/include/QtCore/qmath.h:71: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘qreal qSin(qreal)’:
/usr/include/QtCore/qmath.h:81: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘qreal qCos(qreal)’:
/usr/include/QtCore/qmath.h:91: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘qreal qSqrt(qreal)’:
/usr/include/QtCore/qmath.h:101: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘qreal qLn(qreal)’:
/usr/include/QtCore/qmath.h:111: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h: In function ‘qreal qPow(qreal, qreal)’:
/usr/include/QtCore/qmath.h:121: warning: conversion to ‘float’ from ‘qreal’ may alter its value
/usr/include/QtCore/qmath.h:121: warning: conversion to ‘float’ from ‘qreal’ may alter its value
[ 48%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/application.o
In file included from /usr/include/QtCore/QtCore:82,
                 from /media/susina/home/amroth/kmess/trunk/src/network/msnswitchboardconnection.cpp:20:
/usr/include/QtCore/qbitarray.h: In member function ‘void QBitArray::setBit(int)’:
/usr/include/QtCore/qbitarray.h:126: warning: conversion to ‘unsigned char’ from ‘int’ may alter its value
/usr/include/QtCore/qbitarray.h: In member function ‘void QBitArray::clearBit(int)’:
/usr/include/QtCore/qbitarray.h:130: warning: conversion to ‘unsigned char’ from ‘int’ may alter its value
/usr/include/QtCore/qbitarray.h: In member function ‘bool QBitArray::toggleBit(int)’:
/usr/include/QtCore/qbitarray.h:137: warning: conversion to ‘uchar’ from ‘int’ may alter its value
/usr/include/QtCore/qbitarray.h:138: warning: conversion to ‘uchar’ from ‘int’ may alter its value
/usr/include/QtCore/qbitarray.h:138: warning: conversion to ‘unsigned char’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/msnswitchboardconnection.cpp: In member function ‘void MsnSwitchboardConnection::start(const ChatInformation&)’:
/media/susina/home/amroth/kmess/trunk/src/network/msnswitchboardconnection.cpp:1965: warning: conversion to ‘quint16’ from ‘int’ may alter its value
[ 49%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/applicationlist.o
[ 50%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/filetransfer.o
[ 50%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/filetransferp2p.o
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransfer.cpp: In member function ‘virtual void FileTransfer::userStarted1_UserInvitesContact()’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransfer.cpp:628: warning: conversion to ‘long unsigned int’ from ‘qint64’ may alter its value
[ 51%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/gnomemeeting.o
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransferp2p.cpp: In member function ‘QString FileTransferP2P::createContextField(const QString&, const QFile*, bool) const’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransferp2p.cpp:443: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransferp2p.cpp: In member function ‘virtual void FileTransferP2P::userStarted1_UserInvitesContact()’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/filetransferp2p.cpp:781: warning: conversion to ‘unsigned int’ from ‘qint64’ may alter its value
[ 52%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/inktransferp2p.o
[ 52%] [ 53%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/mimeapplication.o
Building CXX object src/CMakeFiles/kmess.dir/network/applications/msnremotedesktop.o
[ 54%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/p2papplication.o
[ 55%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/msnobjecttransferp2p.o
[ 56%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/sipconnection.o
[ 57%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/voiceconversation.o
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp: In member function ‘void P2PApplication::sendData(QIODevice*, P2PApplication::P2PDataType)’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp:3714: warning: conversion to ‘long unsigned int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp: In member function ‘bool P2PApplication::sendNextDataParts(int)’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp:3900: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp: In member function ‘bool P2PApplication::writeP2PDataToFile(const P2PMessage&, QIODevice*)’:
/media/susina/home/amroth/kmess/trunk/src/network/applications/p2papplication.cpp:5503: warning: conversion to ‘long unsigned int’ from ‘qint64’ may alter its value
[ 57%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/webapplicationp2p.o
[ 58%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/webcamtransferp2p.o
[ 59%] Building CXX object src/CMakeFiles/kmess.dir/network/extra/directconnectionbase.o
[ 60%] Building CXX object src/CMakeFiles/kmess.dir/network/extra/directconnectionpool.o
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:273:2: warning: #warning localPort() returns quint16 in native byte order.
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:773:2: warning: #warning Test how to respond to the various socket error codes.
[ 60%] Building CXX object src/CMakeFiles/kmess.dir/network/extra/msndirectconnection.o
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘int DirectConnectionBase::getAvailableBytes() const’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:213: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘bool DirectConnectionBase::openConnection(const QString&, int)’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:400: warning: conversion to ‘quint16’ from ‘const int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘bool DirectConnectionBase::openServerPort()’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:438: warning: conversion to ‘quint16’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘int DirectConnectionBase::peekBlock(int)’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:470: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘int DirectConnectionBase::readBlock(char*, int)’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:502: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp: In member function ‘bool DirectConnectionBase::writeBlock(const char*, int)’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:942: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/directconnectionbase.cpp:953: warning: conversion to ‘int’ from ‘long long int’ may alter its value
[ 61%] Building CXX object src/CMakeFiles/kmess.dir/network/extra/msnftpconnection.o
[ 62%] Building CXX object src/CMakeFiles/kmess.dir/network/extra/p2pfragmenttracker.o
[ 63%] Building CXX object src/CMakeFiles/kmess.dir/network/soap/httpsoapconnection.o
[ 63%] Building CXX object src/CMakeFiles/kmess.dir/network/soap/msnappdirectoryservice.o
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp: In member function ‘bool MsnFtpConnection::sendFile(QFile*)’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp:388: warning: conversion to ‘long unsigned int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp: In member function ‘void MsnFtpConnection::writeFileData()’:
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp:700: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp:724: warning: conversion to ‘char’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/extra/msnftpconnection.cpp:725: warning: conversion to ‘char’ from ‘int’ may alter its value
[ 64%] Building CXX object src/CMakeFiles/kmess.dir/network/soap/offlineimservice.o
[ 65%] Building CXX object src/CMakeFiles/kmess.dir/network/soap/passportloginservice.o
[ 66%] Building CXX object src/CMakeFiles/kmess.dir/network/soap/soapmessage.o
[ 67%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/igdcontrolpoint.o
[ 67%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/layer3forwardingservice.o
[ 68%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/manager.o
[ 69%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/rootservice.o
[ 70%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/service.o
[ 70%] Building CXX object src/CMakeFiles/kmess.dir/network/upnp/ssdpconnection.o
/media/susina/home/amroth/kmess/trunk/src/network/upnp/service.cpp: In constructor ‘UPnP::Service::Service(const QString&, int, const QString&)’:
/media/susina/home/amroth/kmess/trunk/src/network/upnp/service.cpp:47: warning: conversion to ‘quint16’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/upnp/service.cpp: In constructor ‘UPnP::Service::Service(const UPnP::ServiceParameters&)’:
/media/susina/home/amroth/kmess/trunk/src/network/upnp/service.cpp:64: warning: conversion to ‘quint16’ from ‘const int’ may alter its value
[ 71%] /media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp: In member function ‘void UPnP::SsdpConnection::slotDataReceived()’:
/media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp:82: warning: conversion to ‘int’ from ‘qint64’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp: In member function ‘void UPnP::SsdpConnection::queryDevices(int)’:
/media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp:125: warning: conversion to ‘quint16’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp:132: warning: conversion to ‘int’ from ‘qint64’ may alter its value
Building CXX object src/CMakeFiles/kmess.dir/network/upnp/wanconnectionservice.o
[ 72%] Building CXX object src/CMakeFiles/kmess.dir/notification/notificationchat.o
[ 73%] /media/susina/home/amroth/kmess/trunk/src/notification/notificationchat.cpp:95:2: warning: #warning Temporary calling KWindowSystem::demandAttention() should use KNotify later.
Building CXX object src/CMakeFiles/kmess.dir/notification/notificationcontactstatus.o
[ 73%] Building CXX object src/CMakeFiles/kmess.dir/notification/notificationmanager.o
[ 74%] Building CXX object src/CMakeFiles/kmess.dir/notification/notificationnewemail.o
[ 75%] Building CXX object src/CMakeFiles/kmess.dir/notification/passivepopup.o
[ 76%] Building CXX object src/CMakeFiles/kmess.dir/notification/passivepopupview.o
[ 77%] Building CXX object src/CMakeFiles/kmess.dir/notification/passivepopupwidget.o
[ 77%] Building CXX object src/CMakeFiles/kmess.dir/settings/accountpage.o
[ 78%] Building CXX object src/CMakeFiles/kmess.dir/settings/alertspage.o
[ 79%] Building CXX object src/CMakeFiles/kmess.dir/settings/chatloggingpage.o
[ 80%] Building CXX object src/CMakeFiles/kmess.dir/settings/chatstylepage.o
[ 80%] Building CXX object src/CMakeFiles/kmess.dir/settings/emailpage.o
[ 81%] Building CXX object src/CMakeFiles/kmess.dir/settings/emoticonspage.o
[ 82%] Building CXX object src/CMakeFiles/kmess.dir/settings/settingsdialog.o
[ 83%] Building CXX object src/CMakeFiles/kmess.dir/utils/crashhandler.o
[ 83%] Building CXX object src/CMakeFiles/kmess.dir/utils/idletimer.o
In file included from /usr/include/QtCore/QByteArray:1,
                 from /media/susina/home/amroth/kmess/trunk/src/utils/crashhandler.cpp:22:
/usr/include/QtCore/qbytearray.h: In member function ‘QByteRef::operator char() const’:
/usr/include/QtCore/qbytearray.h:434: warning: conversion to ‘char’ from ‘int’ may alter its value
[ 84%] Building CXX object src/CMakeFiles/kmess.dir/utils/nowlisteningclient.o
[ 85%] Building CXX object src/CMakeFiles/kmess.dir/utils/thumbnailprovider.o
[ 86%] Building CXX object src/CMakeFiles/kmess.dir/utils/xautolock.o
/media/susina/home/amroth/kmess/trunk/src/network/upnp/ssdpconnection.cpp:82: warning: conversion to ‘int’ from ‘qint64’ may alter its value
In file included from /usr/include/QtCore/QByteArray:1,
                 from /media/susina/home/amroth/kmess/trunk/src/utils/xautolock.cpp:20:
/usr/include/QtCore/qbytearray.h: In member function ‘QByteRef::operator char() const’:
/usr/include/QtCore/qbytearray.h:434: warning: conversion to ‘char’ from ‘int’ may alter its value
[ 87%] Building CXX object src/CMakeFiles/kmess.dir/utils/xmlfunctions.o
[ 87%] Building CXX object src/CMakeFiles/kmess.dir/account.o
[ 88%] Building CXX object src/CMakeFiles/kmess.dir/accountaction.o
[ 89%] Building CXX object src/CMakeFiles/kmess.dir/autologinview.o
[ 90%] Building C object src/CMakeFiles/kmess.dir/binreloc.o
[ 90%] Building CXX object src/CMakeFiles/kmess.dir/contactlistviewdelegate.o
[ 91%] Building CXX object src/CMakeFiles/kmess.dir/currentaccount.o
[ 92%] Building CXX object src/CMakeFiles/kmess.dir/emoticon.o
[ 93%] Building CXX object src/CMakeFiles/kmess.dir/emoticonmanager.o
[ 93%] Building CXX object src/CMakeFiles/kmess.dir/emoticontheme.o
[ 94%] Building CXX object src/CMakeFiles/kmess.dir/initialview.o
[ 95%] Building CXX object src/CMakeFiles/kmess.dir/kmessapplication.o
[ 96%] Building CXX object src/CMakeFiles/kmess.dir/kmess.o
[ 97%] Building CXX object src/CMakeFiles/kmess.dir/kmessdebug.o
[ 97%] Building CXX object src/CMakeFiles/kmess.dir/kmessinterface.o
[ 98%] Building CXX object src/CMakeFiles/kmess.dir/kmesstest.o
[ 99%] Building CXX object src/CMakeFiles/kmess.dir/kmessview.o
[100%] Building CXX object src/CMakeFiles/kmess.dir/main.o
[100%] Building CXX object src/CMakeFiles/kmess.dir/systemtraywidget.o
/media/susina/home/amroth/kmess/trunk/src/systemtraywidget.cpp: In member function ‘void SystemTrayWidget::displayCloseMessage(QString)’:
/media/susina/home/amroth/kmess/trunk/src/systemtraywidget.cpp:155: warning: conversion to ‘char’ from ‘int’ may alter its value
/media/susina/home/amroth/kmess/trunk/src/systemtraywidget.cpp:155: warning: conversion to ‘char’ from ‘int’ may alter its value
Linking CXX executable kmess

[valerio]

I've made a (quite huge) patch to fix almost all compiler warnings. Most of the changes are about 'int' port values transformed to 'quint16'. There are some warnings which I couldn't fix, it's been way too long since I've last fiddled with low-level stuff such as byte ordering and couldn't figure out a way to fix them properly. Here are the only remaining warnings with the patch:

/home/valerio/kmess/trunk/src/network/applications/filetransferp2p.cpp: In member function 'QString FileTransferP2P::createContextField(const QString&, const QFile*, bool) const':
/home/valerio/kmess/trunk/src/network/applications/filetransferp2p.cpp:467: warning: conversion to 'unsigned int' from 'ulong' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp: In member function 'void P2PApplicationBase::sendDirectConnectionHandshake(const QString&)':
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1256: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
[ 8%] Building CXX object src/CMakeFiles/kmess.dir/network/applications/msnobjecttransferp2p.o
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp: In member function 'void P2PApplicationBase::sendP2PAckImpl(int, P2PApplicationBase::UnAckedMessage*)':
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1655: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1656: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1658: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1661: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1662: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1663: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp: In member function 'bool P2PApplicationBase::sendP2PMessage(const QByteArray&, int, uint, P2PApplicationBase::P2PMessageType, long unsigned int)':
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1776: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1777: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1778: warning: conversion to 'unsigned int' from 'ulong' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1779: warning: conversion to 'unsigned int' from 'ulong' may alter its value
/home/valerio/kmess/trunk/src/network/applications/p2papplicationbase.cpp:1782: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value

It needs a review, of course.

[diederik]

Are those warnings caused by the patch, or did those already occur? Otherwise, feel free to commit this patch. Looks good to me, and it avoids conflicts when I start with the P2P code.

[valerio]

They were there already; but I couldn't fix them because I couldn't find a safe way to modify,overload or cast on P2PMessage::insertBytes() to make it accept long values without wrecking havoc on file transfers...

[valerio]

Almost all of the warnings were fixed with r3370, closing.