Fix the remaining regressions of the KDE 4 port

[diederik]

Obvious right-in-your-face bugs:

• Resuming a chat does not work. The contact remains gray. Some parts fixed in r2879. Should be fixed in r2894.
• Model is reset when a contact status changes Fixed in r2984.
• Picture browse button doesn't correctly resize/crop the picture. fixed in r2875
• When a font color is selected in the chat window it's reset after opening the account settings. fixed in r2877
• Chat window font dialog does not have the current value selected. fixed in r2876
• Emoticon theme after saving the account settings, because the current one is not selected. fixed in r2880
• Personal status message text is not reset to the <Enter your ... here> text. fixed in r2882

Ok, this is intentional:

• Away/busy are not mixed anymore.

Build process:

• add autopackage checks for binreloc fixed in r3160
• add a configure wrapper, see #206. fixed in r3007
• run cmakelint.pl

[valerio]

For Chat window font dialog does not have the current value selected. I can see the currently used font is selected. Are you sure?

[valerio]

Replying to valerio:

For Chat window font dialog does not have the current value selected. I can see the currently used font is selected. Are you sure?

Nevermind. It's not selected the first time you open a chat.

[diederik]

updated, fixed low hanging fruit :)

[diederik]

found another one: personal status message

[valerio]

Here's the result of cmakelint.pl, after commit r2887 .

$ find -name CMakeLists.txt | xargs ../cmakelint.pl
Processing ./doc/en/CMakeLists.txt:
Processing ./doc/CMakeLists.txt:
Processing ./CMakeLists.txt:
Processing ./kmess/styles/Classic/CMakeLists.txt:
Processing ./kmess/styles/Dim/CMakeLists.txt:
Processing ./kmess/styles/Fresh/CMakeLists.txt:
Processing ./kmess/styles/CMakeLists.txt:
Processing ./kmess/styles/Classic-compact/CMakeLists.txt:
Processing ./kmess/styles/Efficient/CMakeLists.txt:
Processing ./kmess/styles/Colourful-Enclosed/CMakeLists.txt:
Processing ./kmess/styles/Pure/CMakeLists.txt:
Processing ./kmess/pics/CMakeLists.txt:
Processing ./kmess/CMakeLists.txt:
Processing ./kmess/sounds/CMakeLists.txt:
Processing ./po/CMakeLists.txt:
        line#22: replace "${LOCALE_INSTALL_DIR}/${...}" with "${LOCALE_INSTALL_DIR}/realname"

The last one is not harmful since it's for the system locales dir, it's correct as it is now.

[valerio]

I couldn't reproduce Resuming a chat does not work. The contact remains gray at all. The feature seems to be working flawlessly.

Is there some special condition to take care of?

[valerio]

I've made a quick fix for the chat resuming issue. sendMimeMessageWhenReady() was detecting the socket to be connected, when in fact the USR wasn't acknowledged yet - or even not even sent yet.

So KMess sent a CAL to make the last contact to re-join, and the SB server disconnected for protocol breaking. The fix is in r2984 .

[valerio]

I also am unable to reproduce the Model is reset when a contact status changes issue. I tried repeatedly changing status with my main account, with the KMess2 debug build open, and the list always updated just fine.

[diederik]

added the configure wrapper script

[valerio]

All regressions have been successfully fixed. Closing.