Move all popup notifications settings to the KNotify dialog

[amroth]

I think I've found a way to merge all popups and sounds settings. That would be a lot easier than having to configure notifications from two very different places (account settings and Configure Notifications dialog).

Since recently I've moved all KNotify code to the kmess/notification/ classes, it would even be a lot simpler to implement.

• First the user sets the KNotify dialog to display messageboxes, passive or not we can avoid to care. Of course we would set the KNotify defaults accordingly to our current popup balloons default settings.
• Then, in the Notification* classes, we 'override' the KNotifyClient::event() call:
  • Collect all settings for the event we need to send, by using KNotifyClient::getPresentation() and KNotifyClient::getFile()
  • Check from the presentation bitfields if the messagebox presentation mode is on.
  • Delete from the presentation bitfields the Messagebox and Passivepopup modes if set.
  • Call KNotifyClient::userEvent() to send the original event with the usual message, sound, presentation etc but of course without the messagebox presentation modes.
  • If the messagebox presentation mode was set, popup our custom balloon.

[diederik]

Sounds like an interesting idea, but let's not delay the release of 1.5 for it! ;) Also note that KDE 4 will likely change some aspects of this plan.

[amroth]

KDE 4 was something I totally did not think about :P Let's hope that the huge work going on on every KDE4 component will also make KNotify simpler.