Direct connection failure

[amroth]

Direct connections often fail; the problem is a read error on the socket.

kmess: P2PApplication::gotSlpTransferResponse() - Parsing 2nd transfer INVITE message, contact offers to become the direct connection server.
kmess: P2PApplication:gotSlpTransferResponse() - Storing contact nonce value {4189355A-7692-4A8C-989E-73E2FCC1F3DE} to authenticate later.
kmess: P2PApplication::gotSlpTransferResponse() - Contact is listening, attempting to connect to the given IP-address.
kmess: ApplicationList::addConnection: adding new connection attempt.
kmess: ApplicationList: Initializing direct connection pool.
kmess: DirectConnectionPool::addConnection() - Adding new client connection to peer 192.168.1.3:1195
kmess: DirectConnectionBase::openConnection: Connecting to 192.168.1.3 port 1195.
kmess: TransferEntry::setStatusMessage() - displaying 'Connecting to 192.168.1.3, port 1195'.
kmess: ApplicationList::addConnection: adding new connection attempt.
kmess: DirectConnectionPool::addConnection() - Adding new client connection to peer 82.84.250.135:1195
kmess: DirectConnectionBase::openConnection: Connecting to EXTERNAL_IP port 1195.
kmess: P2PApplication::gotSlpTransferResponse() - Waiting for connection attempt to succeed...
kmess: MsnSwitchboardConnection::dataReceived() - Message parsed, buffer length is 0
kmess: DirectConnectionBase::slotSocketFailed: Failed to connect to host
kmess: DirectConnectionPool::slotConnectionFailed() - A direct connection failed.
kmess: DirectConnectionPool::slotConnectionFailed() - There are 1 remaining direct connections, waiting for one to succeed.
kmess: DirectConnectionPool::slotConnectionFailed() - Deleting failed connection to peer :
kmess: WARNING: DirectConnectionBase: Failed to connect to EXTERNAL_IP:1195, system error: Connessione rifiutata.
kmess: DirectConnectionBase::slotSocketConnected() - Connected with host 192.168.1.3:1195.
kmess: DirectConnectionPool::slotConnectionEstablished() - Direct connection established.
kmess: MsnDirectConnection: sending preamble message (0x666f6f00).
kmess: DirectConnectionPool::slotConnectionEstablished() - Connected to peer 192.168.1.3:1195
kmess: ApplicationList: Direct connection with 'contact@kmess.org' established.
kmess: P2PApplication::slotConnectionEstablished() - Direct connection established.
kmess: P2PApplication::sendDirectConnectionHandshake() - Sending direct connection handshake (nonce={4189355A-7692-4A8C-989E-73E2FCC1F3DE}).
kmess: P2PApplication::sendDirectConnectionHandshake() - copied nonce '{4189355A-7692-4A8C-989E-73E2FCC1F3DE}' to p2p message header as '5A358941-9276-8C4A-989E-73E2FCC1F3DE'.
kmess: MsnDirectConnection: sending message block (size=48, handle=contact@kmess.org)
kmess: P2PApplication::sendDirectConnectionHandshake() - Waiting for direct connection handshake response...
kmess: DESTROYED MsnDirectConnection [handle=contact@kmess.org]
kmess: DirectConnectionBase: closing sockets
kmess: DirectConnectionPool::slotConnectionClosed() - Direct connection was closed to peer :
kmess: DirectConnectionPool::slotConnectionClosed() - Closed connection was another pending socket from the pool.
kmess: DESTROYED DirectConnectionBase
kmess: MsnDirectConnection: 4 bytes read, next block size is 48, 4 bytes yet to be read.
kmess: WARNING: MsnDirectConnection: read error (returned -1 block size=48)
kmess: DirectConnectionBase: closing sockets
kmess: DirectConnectionPool::slotConnectionClosed() - Direct connection was closed to peer :
kmess: DirectConnectionPool::slotConnectionClosed() - Closed connection was the active connection!
kmess: ApplicationList: The direct connection with 'contact@kmess.org' was closed.
kmess: DirectConnectionPool: Destructor: Deleting pending sockets and active connection.
kmess: DirectConnectionPool::clearPending() - Removing pending sockets.
kmess: DESTROYED DirectConnectionPool

[amroth]

This is fixed by r2137 .